[google-web-toolkit] [EMAIL PROTECTED] commented on revision r4255.
Details are at  
http://code.google.com/p/google-web-toolkit/source/detail?r=4255

General Comment:
Nice additions to the test. One nit on CalendarUtil

Line-by-line comments:

File:  
/branches/1_6_datepicker/user/src/com/google/gwt/user/datepicker/client/CalendarUtil.java
  
(r4255)
===============================================================================

Line 29:   static DateTimeConstants intlConstants;
-------------------------------------------------------------------------------
This can still be final if you put an else block setting it to null on the  
GWT.isClient()

Respond to these comments at  
http://code.google.com/p/google-web-toolkit/source/detail?r=4255
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to