Mike, I took a look and I think it's a good first pass, definitely a good start! I would actually be excited about a tad bit of refactoring to allow the tests to be more surgical. I think a little bit of work on JJSCompiler could eliminate the need for a rebind oracle entirely, and I think we'd actually rather skip optimizations during initial construction in order to surgically call specific optimizers. Thoughts?
On Tue, Dec 16, 2008 at 9:58 PM, Mike Aizatsky <[email protected]>wrote: > Scott, > > I'm sorry I've disappeared, but I had really busy couple of months. I > have resurrected the change (and all forthcoming). > > Please take another look at the test mini-framework: > > http://codereview.appspot.com/11060 > > On Tue, Oct 14, 2008 at 5:23 AM, Scott Blum <[email protected]> wrote: > > On Mon, Oct 6, 2008 at 5:57 PM, Scott Blum <[email protected]> wrote: > >>> > >>> > By the way, I've already got a big patch out that Bob is reviewing > that > >>> > is a > >>> > huge refactor to JavaToJavaScriptCompiler, and we can continue to > >>> > refactor > >>> > further to support this use case in the best way possible. I can't > >>> > think of > >>> > a fundamental reason that compiles should be slow for small test > cases. > >>> > >>> I'll be happy to take a look at JTJSC and tests as soon as you finish > >>> the refactoring. > >> > >> Cool, if you want, you can chime in on the patch review for that. > > > > Update, this is working its way into the 1.6 release branch. > > > > -- > Regards, > Mike > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
