Updating the copyrights isn't necessary, per a thread a month or two ago that I'll dig up if you make me but I'd really rather not.
On Tue, Jan 13, 2009 at 10:05 AM, <[email protected]> wrote: > > Overall LGTM, but a few nits. Also, remember to update the copyrights > to 2009. > > > > http://gwt-code-reviews.appspot.com/2003/diff/1/3 > File > > reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/VisualsForSuggestBox.java > (right): > > http://gwt-code-reviews.appspot.com/2003/diff/1/3#newcode2 > Line 2: * Copyright 2008 Google Inc. > 2009 > > http://gwt-code-reviews.appspot.com/2003/diff/1/4 > File user/src/com/google/gwt/user/client/ui/MultiWordSuggestOracle.java > (right): > > http://gwt-code-reviews.appspot.com/2003/diff/1/4#newcode241 > Line 241: * be plain text. > Take out "as one might expect". > > http://gwt-code-reviews.appspot.com/2003/diff/1/4#newcode243 > Line 243: * @param suggestionList suggestionList > How about "the default list of suggestions" > > http://gwt-code-reviews.appspot.com/2003/diff/1/6 > File user/src/com/google/gwt/user/client/ui/SuggestOracle.java (right): > > http://gwt-code-reviews.appspot.com/2003/diff/1/6#newcode31 > Line 31: private Response emptyResponse = new Response(new > ArrayList<Suggestion>()); > This should either be a static immutable Response, or a new instance > should be returned each time. Otherwise, a user might manipulate the > return value and mess up future calls. For example, a user might call > "super.requestDefaultSuggestions()" in a subclass, then add suggestions > to the return value. > > http://gwt-code-reviews.appspot.com/2003 > > > > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
