Thanks John. Commited as r4446. On Tue, Jan 13, 2009 at 4:50 PM, John Tamplin <[email protected]> wrote:
> On Mon, Jan 12, 2009 at 11:01 PM, Amit Manjhi <[email protected]>wrote: > >> Please review the attached patch that builds and uses an anonymous class >> mapping to deal with the compiler differences. I made all the changes you >> suggested. In addition, I added another (necessary) condition that the map >> should only be built for non-super-source units. >> > > CompilationUnit.AnonymousClassVisitor.classNames -- the comment appears to > be incorrect, as it looks like the list is all inner classes that aren't > synthetic. > > CompilationUnit.getAnonymousClassMap -- can you give an example of when > this would be true in the comment? > > CompilingClassLoader.isClassnameGenerated -- this regex should be compiled > in a static final field rather than on each use. Ie, > GENERATED_CLASSNAME_PATTERN = Pattern.compile("..."), then get a Matcher > from the pattern in isClassnameGenerated. > > Otherwise LGTM -- feel free to commit when these are fixed. > > -- > John A. Tamplin > Software Engineer (GWT), Google > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
