After some discussion, we are going to merge the two stacks. I'll send out a new code review.
FYI - We will add a method "isTopOfStack()" to NativePreviewEvent that lets users know if this event is at the top of the stack. We'll use an adapter class to convert legacy EventPreview to NativePreviewEvents, but they adapter will check isTopOfStack() before firing. Thanks, John LaBanca [email protected] On Wed, Jan 14, 2009 at 11:44 AM, <[email protected]> wrote: > > http://gwt-code-reviews.appspot.com/2204/diff/1/2 > File user/src/com/google/gwt/user/client/ui/PopupPanel.java (right): > > http://gwt-code-reviews.appspot.com/2204/diff/1/2#newcode787 > Line 787: DOM.addEventPreview(this); > Seems like you should document here (and above in Hide) that you're > using both old and new mechanisms > > http://gwt-code-reviews.appspot.com/2204/diff/1/2#newcode823 > Line 823: @SuppressWarnings("deprecation") > You don't need this suppress any more > > > http://gwt-code-reviews.appspot.com/2204 > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
