I submitted this patch: http://code.google.com/p/google-web-toolkit-incubator/source/detail?r=1553
Uwe On Mar 2, 3:14 pm, Emily Crutcher <e...@google.com> wrote: > LGTM > > > > On Mon, Mar 2, 2009 at 7:49 AM, Uwe Maurer <uwe.mau...@google.com> wrote: > > Hi, > > > I moved the SliderBar to com.google.gwt.gen2.picker.client package, > > and the demo to the corresponding package. > > > I added methods to use the new event handling to the Slider Bar, and > > removed the old event methods. > > I added style injection via Gen2CssInjector. (and added the images and > > css to com.google/gwt/gen2/widgetbase/public) > > > The patch is in the attached file. > > > Thanks, > > Uwe > > > On Fri, Feb 27, 2009 at 5:13 PM, Emily Crutcher <e...@google.com> wrote: > > > The changes look great. Thank you for doing this. Any chance you could > > you > > > create a gen2 version of SliderBar and deprecate the widgetideas version > > > instead on modifying the widgetideas version in place? > > > We are slowly retiring the old widgetideas package in favor of the gen2 > > > package hierarchy, so every time we would have to make a breaking API > > change > > > to a widgetideas widget, we try to deprecate the old one and move the new > > > one into a gen2 package instead. > > > In this case, as the slider is a way to pick a value from a range, it > > would > > > go into the gen2.picker.client package. > > > > Cheers, > > > Emily > > > On Fri, Feb 27, 2009 at 10:32 AM, Uwe Maurer <uwe.mau...@google.com> > > wrote: > > > >> Hi, > > > >> I added methods to use the new event handling to the Slider Bar. > > > >> Also I changed to order of the two public interfaces to make CheckStyle > > >> happy. > > > >> Thanks, > > >> Uwe > > > > -- > > > "There are only 10 types of people in the world: Those who understand > > > binary, and those who don't" > > -- > "There are only 10 types of people in the world: Those who understand > binary, and those who don't" --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
