Author: br...@google.com
Date: Wed Mar 4 13:11:07 2009
New Revision: 4922
Modified:
releases/1.6/doc/build.xml
releases/1.6/user/src/com/google/gwt/debug/client/DebugInfo.java
releases/1.6/user/src/com/google/gwt/user/client/ui/UIObject.java
releases/1.6/user/test/com/google/gwt/debug/client/DebugInfoTest.java
Log:
Hopefully this change will break the build, because it contains a breaking
API change; I want to see if the API checker catches it. See #3 below. A
round of changes related to com.google.gwt.debug.Debug and associated
classes, primarly:
1) Cleaning up the doc for com.google.gwt.debug.client and its classes
2) Removing com.google.gwt.debug.client from the javadoc build because
UIObject.ensureDebugID() is not actually using it; this makes DebugInfo
seem very out of place, and so it's better not to javadoc it until we clean
up how it's used (see issue 3449).
3) BREAKING CHANGE: made the various deferred binding nested impl classes
to support the debug info switch off private instead of public (they
shouldn't have been public to begin with)
4) Added a test case for testing that DebugInfo does the right thing when
the client property "gwt.enableDebugId" is set to "false"; we were only
testing the "true" case before
Review by: jgw (desk)
Modified: releases/1.6/doc/build.xml
==============================================================================
--- releases/1.6/doc/build.xml (original)
+++ releases/1.6/doc/build.xml Wed Mar 4 13:11:07 2009
@@ -10,7 +10,7 @@
<property.ensure name="gwt.dev.jar"
location="${gwt.build.lib}/gwt-dev-linux.jar" />
<property name="USER_PKGS"
-
value="com.google.gwt.animation.client;com.google.gwt.benchmarks.client;com.google.gwt.core.client;com.google.gwt.core.ext;com.google.gwt.core.ext.linker;com.google.gwt.core.ext.typeinfo;com.google.gwt.debug.client;com.google.gwt.dom.client;com.google.gwt.event.dom.client;com.google.gwt.event.logical.shared;com.google.gwt.event.shared;com.google.gwt.http.client;com.google.gwt.i18n.client;com.google.gwt.i18n.rebind.format;com.google.gwt.i18n.rebind.keygen;com.google.gwt.json.client;com.google.gwt.junit.client;com.google.gwt.user.client;com.google.gwt.user.client.rpc;com.google.gwt.user.client.ui;com.google.gwt.user.datepicker.client;com.google.gwt.user.server.rpc;com.google.gwt.xml.client"
/>
+
value="com.google.gwt.animation.client;com.google.gwt.benchmarks.client;com.google.gwt.core.client;com.google.gwt.core.ext;com.google.gwt.core.ext.linker;com.google.gwt.core.ext.typeinfo;com.google.gwt.dom.client;com.google.gwt.event.dom.client;com.google.gwt.event.logical.shared;com.google.gwt.event.shared;com.google.gwt.http.client;com.google.gwt.i18n.client;com.google.gwt.i18n.rebind.format;com.google.gwt.i18n.rebind.keygen;com.google.gwt.json.client;com.google.gwt.junit.client;com.google.gwt.user.client;com.google.gwt.user.client.rpc;com.google.gwt.user.client.ui;com.google.gwt.user.datepicker.client;com.google.gwt.user.server.rpc;com.google.gwt.xml.client"
/>
<property name="LANG_PKGS"
value="java.lang;java.lang.annotation;java.util;java.io;java.sql" />
Modified: releases/1.6/user/src/com/google/gwt/debug/client/DebugInfo.java
==============================================================================
--- releases/1.6/user/src/com/google/gwt/debug/client/DebugInfo.java
(original)
+++ releases/1.6/user/src/com/google/gwt/debug/client/DebugInfo.java Wed
Mar 4 13:11:07 2009
@@ -18,13 +18,15 @@
import com.google.gwt.core.client.GWT;
/**
- * This class provides a set of static methods related to Debugging.
+ * Provides low-level functionality to support the creation of testing and
diagnostic frameworks.
+ *
+ * @see com.google.gwt.user.client.ui.UIObject#ensureDebugId(String)
*/
public class DebugInfo {
/**
* Implementation class for {...@link DebugInfo}.
*/
- public static class DebugInfoImpl {
+ private static class DebugInfoImpl {
public boolean isDebugIdEnabled() {
return false;
}
@@ -33,7 +35,8 @@
/**
* Implementation class for {...@link DebugInfo} used when debug IDs are
enabled.
*/
- public static class DebugInfoImplEnabled extends DebugInfoImpl {
+ @SuppressWarnings("unused")
+ private static class DebugInfoImplEnabled extends DebugInfoImpl {
@Override
public boolean isDebugIdEnabled() {
return true;
Modified: releases/1.6/user/src/com/google/gwt/user/client/ui/UIObject.java
==============================================================================
--- releases/1.6/user/src/com/google/gwt/user/client/ui/UIObject.java
(original)
+++ releases/1.6/user/src/com/google/gwt/user/client/ui/UIObject.java Wed
Mar 4 13:11:07 2009
@@ -97,7 +97,7 @@
* The implementation of the set debug id method, which does nothing by
* default.
*/
- public static class DebugIdImpl {
+ private static class DebugIdImpl {
@SuppressWarnings("unused")
// parameters
public void ensureDebugId(UIObject uiObject, String id) {
@@ -113,7 +113,8 @@
* The implementation of the setDebugId method, which sets the id of the
* {...@link Element}s in this {...@link UIObject}.
*/
- public static class DebugIdImplEnabled extends DebugIdImpl {
+ @SuppressWarnings("unused")
+ private static class DebugIdImplEnabled extends DebugIdImpl {
@Override
public void ensureDebugId(UIObject uiObject, String id) {
uiObject.onEnsureDebugId(id);
Modified:
releases/1.6/user/test/com/google/gwt/debug/client/DebugInfoTest.java
==============================================================================
--- releases/1.6/user/test/com/google/gwt/debug/client/DebugInfoTest.java
(original)
+++ releases/1.6/user/test/com/google/gwt/debug/client/DebugInfoTest.java
Wed Mar 4 13:11:07 2009
@@ -18,7 +18,7 @@
import com.google.gwt.junit.client.GWTTestCase;
/**
- * Test Case for {...@link DebugInfo}.
+ * Test Case for {...@link DebugInfo} when <code>gwt.enableDebugId</code> is
enabled.
*/
public class DebugInfoTest extends GWTTestCase {
--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---
