Author: [email protected]
Date: Fri Mar 6 17:22:55 2009
New Revision: 4955
Modified:
releases/1.6/user/test/com/google/gwt/user/client/ui/ImageTest.java
Log:
Experiment change to try to make image load event tests less flaky, just in
case the events are firing synchronously when the image is cached.
Review by: jgw (TBR)
Modified:
releases/1.6/user/test/com/google/gwt/user/client/ui/ImageTest.java
==============================================================================
--- releases/1.6/user/test/com/google/gwt/user/client/ui/ImageTest.java
(original)
+++ releases/1.6/user/test/com/google/gwt/user/client/ui/ImageTest.java Fri
Mar 6 17:22:55 2009
@@ -118,9 +118,8 @@
}
});
- RootPanel.get().add(image);
-
delayTestFinish(5000);
+ RootPanel.get().add(image);
}
/**
@@ -155,9 +154,8 @@
}
});
- RootPanel.get().add(image);
-
delayTestFinish(5000);
+ RootPanel.get().add(image);
}
/**
@@ -184,12 +182,11 @@
}
});
+ delayTestFinish(5000);
RootPanel.get().add(image);
assertEquals(0, image.getOriginLeft());
assertEquals(0, image.getOriginTop());
assertEquals("unclipped", getCurrentImageStateName(image));
-
- delayTestFinish(5000);
}
/**
@@ -218,9 +215,9 @@
}
});
+ delayTestFinish(5000);
RootPanel.get().add(image);
image.setUrl("counting-backwards.png");
- delayTestFinish(5000);
}
/**
@@ -256,9 +253,9 @@
}
});
+ delayTestFinish(5000);
RootPanel.get().add(image);
assertEquals("unclipped", getCurrentImageStateName(image));
- delayTestFinish(5000);
}
@Override
@@ -302,11 +299,11 @@
});
image.addErrorHandler(new TestErrorHandler(image));
+ delayTestFinish(5000);
RootPanel.get().add(image);
assertEquals(16, image.getOriginLeft());
assertEquals(16, image.getOriginTop());
assertEquals("clipped", getCurrentImageStateName(image));
- delayTestFinish(5000);
}
@SuppressWarnings("deprecation")
@@ -379,10 +376,10 @@
});
image.addErrorHandler(new TestErrorHandler(image));
+ delayTestFinish(5000);
RootPanel.get().add(image);
assertEquals("clipped", getCurrentImageStateName(image));
image.setUrlAndVisibleRect("counting-forwards.png", 0, 16, 16, 16);
- delayTestFinish(5000);
}
/**
@@ -419,12 +416,12 @@
});
image.addErrorHandler(new TestErrorHandler(image));
+ delayTestFinish(5000);
RootPanel.get().add(image);
image.setVisibleRect(0, 0, 16, 16);
image.setVisibleRect(0, 0, 16, 16);
image.setVisibleRect(16, 0, 16, 16);
image.setVisibleRect(16, 8, 8, 8);
- delayTestFinish(5000);
}
/**
--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---
