http://gwt-code-reviews.appspot.com/11801/diff/1/2
File user/src/com/google/gwt/user/client/ui/CheckBox.java (right):

http://gwt-code-reviews.appspot.com/11801/diff/1/2#newcode142
Line 142: }
Nope, but a nice try. What I actually had to do was extend the override
of Widget#sinkEvents to apply to both the checkbox and the label.

In fact, if I add an explicit Event.sinkEvents for label after binding
the handlers here, it breaks dispatch!

On 2009/03/10 20:28:35, jgw wrote:
> If you add this line here:
>      Event.sinkEvents(labelElem, Event.ONMOUSEUP);

> testValueChangeViaLabelClick() will work. The problem here (and yet
another
> reason why I hate CheckBox) is that because it normally sinks events
only on
> inputElem, is that we're not seeing the mouse-up when you click on
labelElem, so
> it's not caching the valueBeforeClick field.

http://gwt-code-reviews.appspot.com/11801

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to