85: Why the change from [a-zA-Z] to [a-z]? FWIW, the tests should check the
validatity of "C:\foo" and "c:\foo".
88: unless I'm missing something, this should read:
String prefix = "^("
Otherwise, you lose the property of checking only start of the URL. Think "
http://evildomain.org/evil?http://localhost:88/";. There should probably
also be a test case that this does not pass.
Also, have you verified that it's actually faster to use a single regex than
to check multiples?
On Mon, Mar 16, 2009 at 11:29 AM, John Tamplin <[email protected]> wrote:
> The attached patch, relative to trunk r5016, adds the name and address of
> the local host machine to the whitelist automatically. In addition, it
> cleans up some cases which were incompletely validated and builds one regex
> rather than requiring iteration.
>
> --
> John A. Tamplin
> Software Engineer (GWT), Google
>
--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---
