[gwt-contrib] Review Request - Make UIObject.DebugIdImpl public

[John LaBanca]

Bruce -

This patch makes UIObject.DebugIdImpl and UIObject.DebugIdImplEnabled public
again.  While it wasn't JavaDoc'd, it is possible to override these classes
using a DeferredBinding, which allows users to set something other than the
ID when UIObject.ensureDebugId() is called.  Some users may be relying on
this behavior in their code.  I created an issue to deprecate these methods
in the next release and add a setter instead.

Associated Issue:
http://code.google.com/p/google-web-toolkit/issues/detail?id=3486

Thanks,
John LaBanca
jlaba...@google.com

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---


Index: user/src/com/google/gwt/user/client/ui/UIObject.java
===================================================================
--- user/src/com/google/gwt/user/client/ui/UIObject.java	(revision 5047)
+++ user/src/com/google/gwt/user/client/ui/UIObject.java	(working copy)
@@ -97,7 +97,7 @@
    * The implementation of the set debug id method, which does nothing by
    * default.
    */
-  private static class DebugIdImpl {
+  public static class DebugIdImpl {
     @SuppressWarnings("unused")
     // parameters
     public void ensureDebugId(UIObject uiObject, String id) {
@@ -114,7 +114,7 @@
    * {...@link Element}s in this {...@link UIObject}.
    */
   @SuppressWarnings("unused")
-  private static class DebugIdImplEnabled extends DebugIdImpl {
+  public static class DebugIdImplEnabled extends DebugIdImpl {
     @Override
     public void ensureDebugId(UIObject uiObject, String id) {
       uiObject.onEnsureDebugId(id);