One real issue: - I really think toStringVerbose() and toStringSimple() should be private methods. (Making them static and taking the object as a parameter would be less bad also.) We have to be super careful about this particular class because it's so magic. Any instance methods you add effectively "own" that name forever, for all overlay types. This could be terribly problematic, especially because of Bob's SingleJsoImpl work.
And one nitpick: - Should be "the given JavaScriptObject" instead of "the give JavaScriptObject" On Tue, Apr 7, 2009 at 8:13 PM, Freeland Abbott <[email protected]> wrote: > Thus, then. > > 2009/4/6 Scott Blum <[email protected]> > > On Mon, Apr 6, 2009 at 9:16 AM, Scott Blum <[email protected]> wrote: >> >>> return JavaScriptObject.class.desiredAssertionStatus() ? >>> toStringVerbose()? : toStringSimple(); >>> >> >> (typo, obviously) >> return JavaScriptObject.class.desiredAssertionStatus() ? toStringVerbose() >> : toStringSimple(); >> > > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
