[gwt-contrib] [google-web-toolkit commit] r5254 - Don't let an exception escape if we can't decode cookies. Future work to

[codesite-noreply]

Author: j...@google.com
Date: Thu Apr 16 15:26:10 2009
New Revision: 5254

Modified:
    trunk/user/src/com/google/gwt/user/client/Cookies.java

Log:
Don't let an exception escape if we can't decode cookies.  Future work to
support non-encoding of cookies is  captured in issue 3566.

Issue: 1633
Patch by: jat
Review by: jgw (desk)


Modified: trunk/user/src/com/google/gwt/user/client/Cookies.java
==============================================================================
--- trunk/user/src/com/google/gwt/user/client/Cookies.java      (original)
+++ trunk/user/src/com/google/gwt/user/client/Cookies.java      Thu Apr 16  
15:26:10 2009
@@ -120,8 +120,16 @@
            name = crumbs[i].substring(0, eqIdx);
            value = crumbs[i].substring(eqIdx + 1);
          }
-        name = decodeURIComponent(name);
-        value = decodeURIComponent(value);
+        try {
+          name = decodeURIComponent(name);
+        } catch (e) {
+          // ignore error, keep undecoded name
+        }
+        try {
+          value = decodeURIComponent(value);
+        } catch (e) {
+          // ignore error, keep undecoded value
+        }
           
m...@java.util.map::put(Ljava/lang/Object;Ljava/lang/Object;)(name,value);
        }
      }

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---