Author: [email protected]
Date: Thu Apr 23 05:14:19 2009
New Revision: 5273
Modified:
trunk/user/src/com/google/gwt/user/client/ui/UIObject.java
trunk/user/test/com/google/gwt/user/client/ui/UIObjectTest.java
Log:
No more failed asserts from UIObjects with no element set.
Fixes issue 3586
Reviewed by: jlabanca
Modified: trunk/user/src/com/google/gwt/user/client/ui/UIObject.java
==============================================================================
--- trunk/user/src/com/google/gwt/user/client/ui/UIObject.java (original)
+++ trunk/user/src/com/google/gwt/user/client/ui/UIObject.java Thu Apr 23
05:14:19 2009
@@ -16,8 +16,8 @@
package com.google.gwt.user.client.ui;
import com.google.gwt.core.client.GWT;
-import com.google.gwt.user.client.DOM;
import com.google.gwt.dom.client.Element;
+import com.google.gwt.user.client.DOM;
/**
* The superclass for all user-interface objects. It simply wraps a DOM
element,
@@ -723,7 +723,7 @@
*/
@Override
public String toString() {
- if (getElement() == null) {
+ if (element == null) {
return "(null handle)";
}
return DOM.toString(getElement());
Modified: trunk/user/test/com/google/gwt/user/client/ui/UIObjectTest.java
==============================================================================
--- trunk/user/test/com/google/gwt/user/client/ui/UIObjectTest.java
(original)
+++ trunk/user/test/com/google/gwt/user/client/ui/UIObjectTest.java Thu Apr
23 05:14:19 2009
@@ -15,6 +15,8 @@
*/
package com.google.gwt.user.client.ui;
+import com.google.gwt.dom.client.Document;
+import com.google.gwt.dom.client.SpanElement;
import com.google.gwt.junit.client.GWTTestCase;
import com.google.gwt.user.client.DOM;
import com.google.gwt.user.client.Element;
@@ -69,6 +71,14 @@
@Override
public String getModuleName() {
return "com.google.gwt.user.DebugTest";
+ }
+
+ public void testToString() {
+ UIObject u = new UIObject(){};
+ assertEquals("(null handle)", u.toString());
+ SpanElement span = Document.get().createSpanElement();
+ u.setElement(span);
+ assertEquals(span.toString(), u.toString());
}
public void testAccidentalPrimary() {
--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---
