Reviewers: jlabanca,

Description:
CheckBoxes were sending two click events when their labels were clicked,
due to trickery going on to send ValueChangeEvents only when
appropriate.

I've moved all the trickery down to RadioButton, the only place it is
actually needed, and filter out click events on the label.

Testing: CheckBoxTest has been extended for the specific problem, and
I've manually tested keyboard and mouse interaction with both CheckBox
and RadioButton on Safari, FF3, IE and Chrome.

Please review this at http://gwt-code-reviews.appspot.com/33801

Affected files:
   user/src/com/google/gwt/user/client/ui/CheckBox.java
   user/src/com/google/gwt/user/client/ui/RadioButton.java
   user/test/com/google/gwt/user/client/ui/CheckBoxTest.java



--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to