One comment on a test that could be shored up; otherwise, LGTM.

http://gwt-code-reviews.appspot.com/34805/diff/1/2
File user/test/com/google/gwt/user/client/CookieTest.java (right):

http://gwt-code-reviews.appspot.com/34805/diff/1/2#newcode163
Line 163: assertEquals(0, cookies.size());
Mind adding a test that would fail if we hadn't added
'encodeURIComponent()' to removeCookie()?

http://gwt-code-reviews.appspot.com/34805

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to