Reviewers: rjrjr,
http://gwt-code-reviews.appspot.com/33823/diff/1/3 File user/src/com/google/gwt/dom/client/InputElement.java (right): http://gwt-code-reviews.appspot.com/33823/diff/1/3#newcode224 Line 224: return !!this.disabled; This was also wrong -- failing to coerce here could lead to unpleasant results in the type system. http://gwt-code-reviews.appspot.com/33823/diff/1/2 File user/test/com/google/gwt/dom/client/ElementTest.java (right): http://gwt-code-reviews.appspot.com/33823/diff/1/2#newcode82 Line 82: assertTrue(input.isDisabled()); The only obvious thing to do here was to test round-tripping the value. At least that tests the type coercion. What ought- and ought-not work (programatically) when an element is disabled is not all that well-defined. Please review this at http://gwt-code-reviews.appspot.com/33823 Affected files: M user/src/com/google/gwt/dom/client/ButtonElement.java M user/src/com/google/gwt/dom/client/InputElement.java M user/test/com/google/gwt/dom/client/ElementTest.java --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
