LGTM

http://gwt-code-reviews.appspot.com/33822/diff/1001/10
File tools/soyc-vis/src/com/google/gwt/soyc/Settings.java (right):

http://gwt-code-reviews.appspot.com/33822/diff/1001/10#newcode121
Line 121: + Settings.settingsHelp());
Maybe explicitly mention the -resources argument in the error message?
That way users don't have to parse the whole settingsHelp() to figure
out what they need to change.

http://gwt-code-reviews.appspot.com/33822/diff/1001/11
File tools/soyc-vis/src/com/google/gwt/soyc/SoycDashboard.java (right):

http://gwt-code-reviews.appspot.com/33822/diff/1001/11#newcode149
Line 149: System.err.println("Cannot open file " + e.getMessage());
The exception could be from something other than opening a file.  Tweak
this message to be more generic?

http://gwt-code-reviews.appspot.com/33822

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to