Reviewers: amit,

Description:
The attached patch makes two changes to java.util.Date in an effort to
track down a very intermittent failure on IE.  IE doesn't provide useful
stack traces for JS-initiated exceptions, so all we know is that jsdate
is uninitialized at some point when it is dereferenced.  The changes
are:
  - use a JSO field storing the JS Date object rather than
    making an expando on the underlying object (which
    couldn't ever work in hosted mode, but since this is a
    JRE emulation class it didn't have to)
  - add checks before each dereference of jsdate to see if it
    is null or undefined; if so throws an NPE so we can get a
    good stack trace.

This does add some overhead, but it shouldn't be too bad.  This is a
temporary change that will be removed once the cause is found.

Please review this at http://gwt-code-reviews.appspot.com/33831

Affected files:
   user/super/com/google/gwt/emul/java/util/Date.java



--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to