One minor nit and one concern.

http://gwt-code-reviews.appspot.com/33838/diff/1/2
File user/src/com/google/gwt/i18n/client/Dictionary.java (right):

http://gwt-code-reviews.appspot.com/33838/diff/1/2#newcode131
Line 131: [email protected]::accessedKeys =
new Array();
Any reason this isn't just [] instead of new Array()?

http://gwt-code-reviews.appspot.com/33838/diff/1/2#newcode147
Line 147:
[email protected]::accessedKeys.push(key);
I worry about how big this could potentially get.  What if the same key
is accessed many times?  Perhaps it would be better to keep only the
last n keys.

http://gwt-code-reviews.appspot.com/33838

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to