I'll upload a new patch in a minute.
http://gwt-code-reviews.appspot.com/33804/diff/24/31 File dev/core/src/com/google/gwt/core/ext/linker/impl/StandardStatementRanges.java (right): http://gwt-code-reviews.appspot.com/33804/diff/24/31#newcode27 Line 27: private static int[] toArray(List<Integer> list) { I changed the types to ArrayList. http://gwt-code-reviews.appspot.com/33804/diff/24/33 File dev/core/src/com/google/gwt/core/linker/IFrameLinker.java (right): http://gwt-code-reviews.appspot.com/33804/diff/24/33#newcode64 Line 64: if (charsPerChunk < 0) { Actually, the results would be different and possibly longer, because it would no longer undo the IEBlockSizeVisitor.... Do you think this should be short-circuited anyway? http://gwt-code-reviews.appspot.com/33804/diff/24/33#newcode68 Line 68: StringBuffer sb = new StringBuffer(); Changed. Since this method is getting modified anyway, I also tweaked it not to actually extract the "stmt" string. http://gwt-code-reviews.appspot.com/33804/diff/24/43 File user/src/com/google/gwt/core/CompilerParameters.gwt.xml (right): http://gwt-code-reviews.appspot.com/33804/diff/24/43#newcode19 Line 19: This is the maximum number of variables in any var statement GWT will emit. This avoids a bug in Yes. I tried 80, but it caused excess wrapping, so I switched to 100. I then auto-wrapped everything, because I was spending a lot of time manually reformatting. Do we have an XML style guide? http://gwt-code-reviews.appspot.com/33804/diff/24/44 File user/super/com/google/gwt/emul/java/lang/Class.java (right): http://gwt-code-reviews.appspot.com/33804/diff/24/44#newcode123 Line 123: + (seedName != null ? seedName : "" + clazz.hashCode()); Done. r5494. http://gwt-code-reviews.appspot.com/33804/diff/24/42 File user/test/com/google/gwt/emultest/EmulSuite.gwt.xml (right): http://gwt-code-reviews.appspot.com/33804/diff/24/42#newcode25 Line 25: <set-configuration-property name='iframe.linker.script.chunk.size' value='100'/> Any test should do; it's just an end to end test verifying that there is no catastrophic breakage when script chunking is turned on. Likewise for vars-line splitting. Shall I move them both to CompilerSuite? Neither? http://gwt-code-reviews.appspot.com/33804 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
