On Wed, Jun 3, 2009 at 11:07 AM, John Tamplin <[email protected]> wrote:
> On Wed, Jun 3, 2009 at 10:56 AM, Eric Ayers <[email protected]> wrote: > >> protected String generateSelectionScript(...) { >> ... >> String gwtVersions[] = About.GWT_VERSION_NUM.split("\\."); >> replaceAll(scriptContents, "__GWT_MAJOR_VERSION__", gwtVersions[0] + >> "." >> + gwtVersions[1]); >> return scriptContents.toString(); >> } >> >> The problem I'm having is that I believe that About.GWT_VERSION_NUM is >> being baked into the .class files generated when I compile gwt-gadgets.jar >> (with GWT 1.5 as it turns out). I think this needs to turn into a getter >> instead. >> > > Yes, constants can be inlined into external classes (which I think was an > absolutely horrible idea in Java as it breaks separate compilation), and > using a getter will fix that. > Last time we discussed this section of code, there was talk of moving the version number elsewhere, but that was pre OOPHM. Discussion? (previous thread) https://groups.google.com/group/Google-Web-Toolkit-Contributors/browse_thread/thread/e31b5af48a6bf746/cdb5cb5f5829b739 -- Eric Z. Ayers - GWT Team - Atlanta, GA USA http://code.google.com/webtoolkit/ --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
