Minor naming, suggestion for modifying GwtVersion, otherwise LGTM.
http://gwt-code-reviews.appspot.com/33841/diff/1/10 File dev/core/src/com/google/gwt/dev/About.java (right): http://gwt-code-reviews.appspot.com/33841/diff/1/10#newcode90 Line 90: public static String getGWTName() { use camelcase instead? ie, getGwtName http://gwt-code-reviews.appspot.com/33841/diff/1/10#newcode100 Line 100: public static String getGWTSvnRev() { and here http://gwt-code-reviews.appspot.com/33841/diff/1/10#newcode107 Line 107: public static String getGWTVersion() { and here http://gwt-code-reviews.appspot.com/33841/diff/1/10#newcode117 Line 117: public static int[] getGWTVersionArray() { and here http://gwt-code-reviews.appspot.com/33841/diff/1/10#newcode135 Line 135: public static String getGWTVersionNum() { and here http://gwt-code-reviews.appspot.com/33841/diff/1/12 File dev/core/src/com/google/gwt/dev/shell/CheckForUpdates.java (right): http://gwt-code-reviews.appspot.com/33841/diff/1/12#newcode360 Line 360: myVersion = new GwtVersion(About.getGWTVersionNum()); Could change GwtVersion to use int[] instead, since it does that internally. http://gwt-code-reviews.appspot.com/33841 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
