Reviewers: jgw, Description: A few miscellaneous fixes for JS issues. We might also want to merge into releases/1.6.
Please review this at http://gwt-code-reviews.appspot.com/42802 Affected files: user/src/com/google/gwt/dom/client/OptionElement.java user/src/com/google/gwt/dom/client/TableSectionElement.java user/src/com/google/gwt/user/client/ui/PrefixTree.java Index: user/src/com/google/gwt/dom/client/OptionElement.java --- user/src/com/google/gwt/dom/client/OptionElement.java (revision 5396) +++ user/src/com/google/gwt/dom/client/OptionElement.java (working copy) @@ -42,7 +42,7 @@ public class OptionElement extends Element { * control is not within the context of a form. */ public final native FormElement getForm() /*-{ - return form; + return this.form; }-*/; /** Index: user/src/com/google/gwt/dom/client/TableSectionElement.java --- user/src/com/google/gwt/dom/client/TableSectionElement.java (revision 3193) +++ user/src/com/google/gwt/dom/client/TableSectionElement.java (working copy) @@ -92,7 +92,7 @@ public class TableSectionElement extends Element { * HTMLTheadElement for details. */ public final native String getVAlign() /*-{ - return this.valign; + return this.vAlign; }-*/; /** @@ -140,6 +140,6 @@ public class TableSectionElement extends Element { * HTMLTheadElement for details. */ public final native void setVAlign(String vAlign) /*-{ - this.valign = valign; + this.vAlign = vAlign; }-*/; } Index: user/src/com/google/gwt/user/client/ui/PrefixTree.java --- user/src/com/google/gwt/user/client/ui/PrefixTree.java (revision 2332) +++ user/src/com/google/gwt/user/client/ui/PrefixTree.java (working copy) @@ -41,6 +41,8 @@ class PrefixTree extends AbstractCollection<String> { */ private static class PrefixTreeIterator implements Iterator<String> { + @SuppressWarnings("unused") + // Called from JSNI. private JavaScriptObject stack; /** @@ -99,7 +101,7 @@ class PrefixTree extends AbstractCollection<String> { */ private native void addTree(PrefixTree tree, String prefix) /*-{ var suffixes = []; - for (suffix in [email protected]::suffixes) { + for (var suffix in [email protected]::suffixes) { suffixes.push(suffix); } @@ -162,7 +164,7 @@ class PrefixTree extends AbstractCollection<String> { // Put all subframes on the stack, and return to top of loop. } else { - for (key in frame.subtrees) { + for (var key in frame.subtrees) { var target = frame.prefix + unsafe(key); var subtree = frame.subtrees[key]; @@ -411,7 +413,7 @@ class PrefixTree extends AbstractCollection<String> { // The answer can only exist in this tree's suffixes or subtree keys. } else { // Check local suffixes. - for (suffix in suffixes) { + for (var suffix in suffixes) { var target = prefix + @com.google.gwt.user.client.ui.PrefixTree::unsafe(Ljava/lang/String;)(suffix); if (target.indexOf(search) == 0) { [email protected]::add(Ljava/lang/Object;)(target); --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
