LGTM
On Tue, Jun 23, 2009 at 12:10 PM, Freeland Abbott<fabb...@google.com> wrote:
> Substitute with this version, having discovered structural errors with
> samples (${project.build} is lowercase, but output is uppercase) and some
> comments from Eric regarding the presubmit target (which are actually
> orthogonal, but since I'm here....)
>
>
>
> On Tue, Jun 23, 2009 at 11:32 AM, Freeland Abbott <fabb...@google.com>
> wrote:
>>
>> Previously, it failed in the <checkstyle> rule, and didn't even reach the
>> helpfully explanatory <echo>. This changes the <echo> to a <fail>, and
>> delays failure a bit, so that we only get the output if there is an error,
>> but we do get it.
>>
>
>
--
Eric Z. Ayers - GWT Team - Atlanta, GA USA
http://code.google.com/webtoolkit/
--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---
