LGTM with comments.

http://gwt-code-reviews.appspot.com/47804/diff/1/3
File user/src/com/google/gwt/junit/client/GWTTestCase.java (right):

http://gwt-code-reviews.appspot.com/47804/diff/1/3#newcode52
Line 52: * {...@link UnsupportedOperationException}.Instead, override
{...@link #gwtSetUp()}
While you're here, the existing comment was missing a space after the
end of the previous sentence.  But it would probably be best to commit
formatting-only changes separately to avoid confusing the semantic
change.

http://gwt-code-reviews.appspot.com/47804/diff/1/3#newcode229
Line 229: super.runTest();
Food for thought: consider setting up a default GWT.create() bridge
somehow?

http://gwt-code-reviews.appspot.com/47804

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to