LGTM after the change below.

http://gwt-code-reviews.appspot.com/48803/diff/1/3
File user/src/com/google/gwt/i18n/rebind/ResourceFactory.java (right):

http://gwt-code-reviews.appspot.com/48803/diff/1/3#newcode183
Line 183: Resource resource = resourceMap.get(path);
I think this is going to have the same problem as what Bob found before,
where some resources are on the classpath but not in any module prefix.

So, I think it needs to fallback to looking in the classloader if lookup
in resourceMap fails.

http://gwt-code-reviews.appspot.com/48803

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to