LGTM with comments
http://gwt-code-reviews.appspot.com/46801/diff/1041/26 File dev/core/src/com/google/gwt/dev/jdt/AbstractCompiler.java (right): http://gwt-code-reviews.appspot.com/46801/diff/1041/26#newcode504 Line 504: protected String[] doFindAdditionalTypesUsingArtificialRescues( Yeah, I'll update something in trunk/eclipse. http://gwt-code-reviews.appspot.com/46801/diff/1041/41 File dev/core/test/com/google/gwt/dev/javac/CheckerTestCase.java (right): http://gwt-code-reviews.appspot.com/46801/diff/1041/41#newcode95 Line 95: } After more thinking about it, I think binary-only-annotations support is allowing this to happen. http://gwt-code-reviews.appspot.com/46801/diff/5008/4010 File dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java (right): http://gwt-code-reviews.appspot.com/46801/diff/5008/4010#newcode1087 Line 1087: visitor.accept(new ArrayList<JArrayType>(allArrayTypes)); Could we just do a GenerateJavaScriptAst.endVisit(JProgram) to export these symbols manually? Otherwise you're needlessly slowing down the rest of the compile. http://gwt-code-reviews.appspot.com/46801 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
