I keep getting 500's, but basically LGTM. Though the nested if stuff is a bit torturous to follow. :)
On Tue, Jul 7, 2009 at 6:14 PM, <[email protected]> wrote: > Reviewers: scottb, chassande_gmail.com, > > Description: > This is in response to Sebastien's complaint of 1jul09, that trunk > didn't compile because his French svn info gave output that didn't match > our English regexps. > > There are two parts to this: > 1. If the output propety is already defined, don't > run svn, don't match the output, don't risk failing. > That would have given Sebastien a workaround, by > defining gwt.svnrev in local.ant.properties. > 2. Change the regexps to be word-neutral, so that they > don't care about the language of the tags, just the > shape of the values. This trades a language > sensitivity for a positional one. > > Please review this at http://gwt-code-reviews.appspot.com/48807 > > Affected files: > SvnInfo.java > > > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
