As people use dist-dev, they're more likely to have samples unbuilt (i.e. no
build/out/samples/...).As checkstyle is now fatal, and becoming part of
top-level tests, checkstyle will tend to run in unbuilt samples.
Today, this is Bad. But with this fix, it may become Happy. Or it may
Explode.
All eyes are on you, Ray... no pressure.
Index: common.ant.xml
===================================================================
--- common.ant.xml (revision 5714)
+++ common.ant.xml (working copy)
@@ -276,6 +276,7 @@
<element name="sourcepath" implicit="yes" optional="true" />
<sequential>
<taskdef resource="checkstyletask.properties"
classpath="${gwt.tools.antlib}/checkstyle-all-4.2.jar;${gwt.build.lib}/gwt-customchecks.jar"
/>
+ <mkdir dir="@{outputdirectory}"/>
<checkstyle
config="${gwt.root}/eclipse/settings/code-style/gwt-checkstyle.xml"
maxErrors="0" failOnViolation="false"
failureProperty="gwt.checkstyle.failed">
<formatter type="xml"
toFile="@{outputdirectory}/checkstyle_log.xml"/>
<property key="checkstyle.header.file"
file="${gwt.root}/eclipse/settings/code-style/google.header" />
--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---
