Good catch. LGTM On Fri, Jul 10, 2009 at 9:40 PM, <[email protected]> wrote:
> Reviewers: amitmanjhi, > > Description: > the old form got confused by a refJar "path" of > > 'C:\GWT\tools\api-checker\reference\gwt-dev-modified.jar:C:\GWT\tools\api-checker\reference\gwt-user-modified.jar' > because splitting on colons was wrong. Worse, ant thought that it had > succeeded because an arg-parsing error was caught, help printed, and > ultimately 0 exited. > > The new form splits on the path.separator system propery instead, uses > ant's <arg path=.../> to input either a : or ; separated value depending > on OS, and catches arg parse failures as non-zero return. > > Please review this at http://gwt-code-reviews.appspot.com/51801 > > Affected files: > build.xml > > > tools/api-checker/src/com/google/gwt/tools/apichecker/ApiCompatibilityChecker.java > > > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
