Dan, can you add the test that would have caught that for you? On Thu, Jul 16, 2009 at 10:47 AM, Daniel Rice (דניאל רייס) <[email protected]>wrote:
> Sorry, fixed. > Dan > > > On Thu, Jul 16, 2009 at 1:35 PM, Joel Webber <[email protected]> wrote: > >> Seems I'm blind; thanks Ian. Mind changing that, Dan? We really need tests >> for this stuff sometime soon -- of course, other than syntax bugs like this, >> it's damned near impossible to test this sort of thing, because so many of >> these properties have no testable effects, and having a typo in the property >> name just gives you an expando... >> >> >> On Thu, Jul 16, 2009 at 1:30 PM, Ian Petersen <[email protected]> wrote: >> >>> >>> On Thu, Jul 16, 2009 at 8:12 AM, <[email protected]> wrote: >>> > Index: user/src/com/google/gwt/dom/client/AnchorElement.java >>> > =================================================================== >>> > --- user/src/com/google/gwt/dom/client/AnchorElement.java >>> (revision 5739) >>> > +++ user/src/com/google/gwt/dom/client/AnchorElement.java >>> (working copy) >>> > @@ -165,7 +165,7 @@ >>> > * @see <a >>> > href=" >>> http://www.w3.org/TR/1999/REC-html401-19991224/struct/links.html#adef-rel >>> ">W3C >>> > HTML Specification</a> >>> > */ >>> > public final native void setRel(String name) /*-{ >>> > - this.name = name; >>> > + this.rel = rel; >>> > }-*/; >>> >>> Is that right? Do you need to change the argument's name from "name" >>> to "rel" or is there some bug in the diff? >>> >>> Ian >>> >>> >>> >> >> >> > > > > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
