LGTM.

http://gwt-code-reviews.appspot.com/47816/diff/3008/1037
File dev/core/src/com/google/gwt/dev/js/JsStackEmulator.java (right):

http://gwt-code-reviews.appspot.com/47816/diff/3008/1037#newcode68
Line 68: private class Bootstrap extends JsVisitor {
"Bootstrap" took me a few minutes to figure out.  I think it is
bootstrapping the visitation?  If so, then something like
"InstrumentAllFunctions" looks more direct.

http://gwt-code-reviews.appspot.com/47816/diff/3008/1037#newcode748
Line 748: private boolean recordLineNumbers =
Boolean.getBoolean("gwt.dev.stack.recordLineNumbers");
Don't forget to change these to configuration properties, if it looks
good to you.  As further motivation, if they were config properties,
then an individual GWTTestCase could turn on the extra recording just
for itself.

http://gwt-code-reviews.appspot.com/47816

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to