Mostly LGTM.

http://gwt-code-reviews.appspot.com/51816/diff/1/2
File dev/core/src/com/google/gwt/dev/js/JsParser.java (right):

http://gwt-code-reviews.appspot.com/51816/diff/1/2#newcode159
Line 159: SourceInfo toReturn = program.createSourceInfo(lineno,
parent.getFileName());
Why can't we use the same SourceInfo instance if we borrow the parent's
info?

http://gwt-code-reviews.appspot.com/51816/diff/1/2#newcode355
Line 355: @SuppressWarnings("unchecked")
All this stuff is really separate, right?

http://gwt-code-reviews.appspot.com/51816

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to