Looks good. A couple of nitpicks, and I want to see it in action, but no problems so far.
http://gwt-code-reviews.appspot.com/51830/diff/1/2 File layout/Layout.gwt.xml (right): http://gwt-code-reviews.appspot.com/51830/diff/1/2#newcode17 Line 17: <inherits name="com.google.gwt.user.UserAgent"/> Fix indent spacing http://gwt-code-reviews.appspot.com/51830/diff/1/2#newcode19 Line 19: <inherits name="com.google.gwt.animation.Animation"/> Fix indent spacing http://gwt-code-reviews.appspot.com/51830/diff/1/5 File layout/client/Layout.java (right): http://gwt-code-reviews.appspot.com/51830/diff/1/5#newcode68 Line 68: * <code> This code should be moved to the examples directory. http://gwt-code-reviews.appspot.com/51830/diff/1/5#newcode102 Line 102: * warning. Use at your own risk. Do we need a TODO to remove this when we release? Or are we going to change the layout after we release? http://gwt-code-reviews.appspot.com/51830/diff/1/5#newcode154 Line 154: Object userData; Should this be a parameterized type? http://gwt-code-reviews.appspot.com/51830/diff/1/5#newcode177 Line 177: * This is the element that sits between the parent and child elements. It typo - "It is normally", not "It normally" http://gwt-code-reviews.appspot.com/51830/diff/1/3 File layout/client/LayoutImpl.java (right): http://gwt-code-reviews.appspot.com/51830/diff/1/3#newcode2 Line 2: * Copyright 2008 Google Inc. 2009 http://gwt-code-reviews.appspot.com/51830/diff/1/4 File layout/client/LayoutImplIE6.java (right): http://gwt-code-reviews.appspot.com/51830/diff/1/4#newcode2 Line 2: * Copyright 2008 Google Inc. 2009 http://gwt-code-reviews.appspot.com/51830/diff/1/11 File user/client/ui/LayoutPanel.java (right): http://gwt-code-reviews.appspot.com/51830/diff/1/11#newcode41 Line 41: * // Attach two child widgets, laying them out horizontally, splitting at 50%. This code should be moved to the examples directory. http://gwt-code-reviews.appspot.com/51830/diff/1/11#newcode142 Line 142: assert child.getParent() == this : "TODO"; You should put a message here http://gwt-code-reviews.appspot.com/51830/diff/1/12 File user/client/ui/RootLayoutPanel.java (right): http://gwt-code-reviews.appspot.com/51830/diff/1/12#newcode48 Line 48: * // Attaches a pair of widgets to the RootLayoutPanel Move to examples directory http://gwt-code-reviews.appspot.com/51830 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
