LGTM with nits.
http://gwt-code-reviews.appspot.com/55803/diff/1/3 File user/test/com/google/gwt/emultest/java/util/EnumSetTest.java (right): http://gwt-code-reviews.appspot.com/55803/diff/1/3#newcode54 Line 54: if (array[0] != Numbers.One && array[1] != Numbers.One) { What about set.contains() here? It looks like what you really one is for testDuplicates() to use set.contains() and perhaps have a separate testToArray() to make assertions about the array returned from set.toAarry(). http://gwt-code-reviews.appspot.com/55803/diff/1/3#newcode60 Line 60: } catch (NoSuchElementException bug) { No need for this try/catch block; the general pattern is to allow all unchecked exceptions to escape. The JUnit infrastructure will report the escaped exception. http://gwt-code-reviews.appspot.com/55803 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
