LGTM

Just change onAttached/onDetached to onAttach/onDetach.


http://gwt-code-reviews.appspot.com/55804/diff/1/6
File user/src/com/google/gwt/layout/client/Layout.java (right):

http://gwt-code-reviews.appspot.com/55804/diff/1/6#newcode495
Line 495: public void onAttached() {
Should be onAttach() instead of the past tense.  Alternatively, you can
use the tense used to describe an event that you traveled into the
future in order to avoid.

http://gwt-code-reviews.appspot.com/55804

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to