Reviewers: bobv,
Description:
This is the native-code portion of the changes to the OOPHM wire
protocol and initialization sequence.
The common code and XPCOM changes have been tested, the IE and WebKit
changes have not so there may be obvious errors there (especially since
I am not familiar with Objective-C++ for the WebKit version).
I'll post the Java and hosted.html changes in a separate review.
The wire protocol changes are to address the following issues:
- the need for additional data necessary for UI changes
- better protocol versioning support
- enable future features such as transport selection (ie,
shared memory).
An init method is added on the plugin object to separate out the ability
to properly initialize the plugin (which means to keep looking for a
valid plugin) vs. some failure connecting to the hosted mode server (ie,
bad address, network connectivity, or protocol version mismatch). I
think connect should also be changed to return a string error message on
failure and null on success to get a better error message, but that will
be in a later patch.
Please review this at http://gwt-code-reviews.appspot.com/51834
Affected files:
plugins/common/AllowedConnections.cpp
plugins/common/AllowedConnections.h
plugins/common/BrowserChannel.h
plugins/common/CheckVersionsMessage.cpp
plugins/common/CheckVersionsMessage.h
plugins/common/ChooseTransportMessage.cpp
plugins/common/ChooseTransportMessage.h
plugins/common/FatalErrorMessage.cpp
plugins/common/FatalErrorMessage.h
plugins/common/HostChannel.cpp
plugins/common/HostChannel.h
plugins/common/LoadModuleMessage.cpp
plugins/common/LoadModuleMessage.h
plugins/common/Makefile
plugins/common/ProtocolVersionMessage.cpp
plugins/common/ProtocolVersionMessage.h
plugins/common/SessionHandler.h
plugins/common/SwitchTransportMessage.cpp
plugins/common/SwitchTransportMessage.h
plugins/ie/oophm/oophm/IESessionHandler.cpp
plugins/ie/oophm/oophm/IESessionHandler.h
plugins/ie/oophm/oophm/oophm.idl
plugins/ie/oophm/oophm/plugin.cpp
plugins/ie/oophm/oophm/plugin.h
plugins/webkit/Core/WebScriptSessionHandler.cpp
plugins/webkit/Core/WebScriptSessionHandler.h
plugins/webkit/Plugin/OophmWebScriptObject.h
plugins/webkit/Plugin/OophmWebScriptObject.mm
plugins/xpcom/ExternalWrapper.cpp
plugins/xpcom/FFSessionHandler.cpp
plugins/xpcom/FFSessionHandler.h
plugins/xpcom/IOOPHM.idl
--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---
