Reviewed the common, ie, and webkit code. LGTM
http://gwt-code-reviews.appspot.com/51834/diff/1/11 File plugins/common/ChooseTransportMessage.cpp (right): http://gwt-code-reviews.appspot.com/51834/diff/1/11#newcode31 Line 31: * Receive an FatalError message from the channel (note that the message Copy-and-paste? http://gwt-code-reviews.appspot.com/51834/diff/1/13 File plugins/common/FatalErrorMessage.h (right): http://gwt-code-reviews.appspot.com/51834/diff/1/13#newcode27 Line 27: * Class representing an InvokeMessage received from the server, and a way Copy-and-paste? http://gwt-code-reviews.appspot.com/51834/diff/1/26 File plugins/common/ProtocolVersionMessage.h (right): http://gwt-code-reviews.appspot.com/51834/diff/1/26#newcode27 Line 27: * Class representing an InvokeMessage received from the server, and a way Copy-and-paste http://gwt-code-reviews.appspot.com/51834/diff/1/17 File plugins/common/SwitchTransportMessage.cpp (right): http://gwt-code-reviews.appspot.com/51834/diff/1/17#newcode29 Line 29: * Receive a SwitchTransport message from the server. What is this message type used for? http://gwt-code-reviews.appspot.com/51834/diff/1/27 File plugins/common/SwitchTransportMessage.h (right): http://gwt-code-reviews.appspot.com/51834/diff/1/27#newcode27 Line 27: * Class representing an InvokeMessage received from the server, and a way Copy-and-paste. http://gwt-code-reviews.appspot.com/51834/diff/1/2 File plugins/webkit/Core/WebScriptSessionHandler.cpp (right): http://gwt-code-reviews.appspot.com/51834/diff/1/2#newcode97 Line 97: Debug::log(Debug::Error) << "Fatal error: " << message << Debug::flush; There's a CrashHandler mechanism already built into the plugin, you can call that to initiate an orderly shutdown. http://gwt-code-reviews.appspot.com/51834/diff/1/5 File plugins/webkit/Plugin/OophmWebScriptObject.mm (right): http://gwt-code-reviews.appspot.com/51834/diff/1/5#newcode98 Line 98: - (BOOL)initForWebScriptWithJsniContext: (WebScriptObject*) jsniContext { Just to confirm that this is intended to be a no-op? http://gwt-code-reviews.appspot.com/51834 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
