Thanks, Kathrin.  I just had a couple of nits myself.

http://gwt-code-reviews.appspot.com/60802/diff/1/2
File
dev/core/src/com/google/gwt/core/ext/soyc/impl/DependencyRecorder.java
(right):

http://gwt-code-reviews.appspot.com/60802/diff/1/2#newcode110
Line 110: logger = logger.branch(TreeLogger.INFO,
Should this also be dialed down?

http://gwt-code-reviews.appspot.com/60802/diff/1/6
File dev/core/src/com/google/gwt/dev/Compiler.java (right):

http://gwt-code-reviews.appspot.com/60802/diff/1/6#newcode214
Line 214: if (options.getWarDir() != null) {
Is it possible for this to be null here?  I can't repro this case.  -out
is illegal for this entry point and -war defaults 'war' if you don't
specify.

http://gwt-code-reviews.appspot.com/60802/diff/1/4
File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
(left):

http://gwt-code-reviews.appspot.com/60802/diff/1/4#oldcode204
Line 204: if (JProgram.isTracingEnabled()) {
Could I lobby for leaving this one alone?  The big banner is visually
important for gwt.jjs.traceMethods (which always go to STDOUT, not the
TreeLogger).

http://gwt-code-reviews.appspot.com/60802

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to