This is a nice cleanup, but I have questions about your annotation search
http://gwt-code-reviews.appspot.com/61802/diff/1011/18 File user/src/com/google/gwt/resources/ext/ResourceGeneratorUtil.java (right): http://gwt-code-reviews.appspot.com/61802/diff/1011/18#newcode135 Line 135: public static <T extends Annotation> T findAnnotation(TreeLogger logger, logger appears to be unused. Is there an appropriate more general home for this? I know I do it all the time. Could it be an instance method on JClassType? Also, you don't appear to be looking for the @Inherited meta annotation, and by trawling through super types and interfaces won't you pick up annotations that aren't marked that way? For annotations marked @Inherited, would the super-crawl even be necessary? http://gwt-code-reviews.appspot.com/61802 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
