Reviewers: jlabanca, Description: This is the simplest possible fix for issue 3973: ensure that hookEvents and unhookEvents are called even when not using a synthesized iframe (FormPanelImpl and FormPanelImplIE6 already handle the case where 'iframe' is null)
A better fix IMO would be to also fix issue 2796 and use addDomHandler(handler, SubmitEvent.getType()), but there's the trick with iframe.__action in FormPanelImpl to workaround spurious iframe loads in IE, so it's not as easy (and there's the setCancelled(boolean) method on SubmitEvent for backwards compatibility, which I think couldn't be made to work on a DomEvent) Giving it to jlabanca as he's the last one who modified FormPanel (so is probably the one responsible for it) Please review this at http://gwt-code-reviews.appspot.com/62801 Affected files: reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/DefaultMuseum.java reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/Issue3973.java user/src/com/google/gwt/user/client/ui/FormPanel.java user/test/com/google/gwt/user/UISuite.java user/test/com/google/gwt/user/client/ui/FormPanelTest.java --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
