On 2009/08/20 15:39:30, knorton wrote: > lgtm, w/ just one random comment.
> http://gwt-code-reviews.appspot.com/61805/diff/1/2 > File dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html (right): > http://gwt-code-reviews.appspot.com/61805/diff/1/2#newcode276 > Line 276: // look for the old query parameter if we don't find the new one > This looks correct to me, but I do think the logic in this file could be a lot > more manageable. For instance, it seems like the straight line could could just > read: > $hosted = getCodeSvrQueryParam() || getLegacyHostedQueryParam(); > Much of the logic now is in the straight line execution and not well > encapsulated in functions. I'm not necessarily suggesting that you get it all > organized before this commit, but I do think it would be good to start cleaning > this up in preparation for maintaining it effectively long-term. I expanded the TODO to include refactoring, committed at 5981. http://gwt-code-reviews.appspot.com/61805 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
