Alright, settle down. You're doing my work too fast. Oh, wait -- that's a
good thing :)

On Thu, Aug 20, 2009 at 3:00 PM, <[email protected]> wrote:

>
> Thanks for the patches.  Looks like there is some auto-format cruft, but
> it LGTM overall.
>
>
> http://gwt-code-reviews.appspot.com/61809/diff/1/6
> File user/src/com/google/gwt/dom/client/DOMImplTrident.java (right):
>
> http://gwt-code-reviews.appspot.com/61809/diff/1/6#newcode220
> Line 220: return parent == child;
> There are a few syntax errors throughout this file.  Each of the inner
> statements should be tabbed over a couple of spaces.
>
> http://gwt-code-reviews.appspot.com/61809/diff/1/8
> File user/src/com/google/gwt/user/client/ui/ResetButton.java (right):
>
> http://gwt-code-reviews.appspot.com/61809/diff/1/8#newcode2
> Line 2: * Copyright 2006 Google Inc.
> 2009
>
> http://gwt-code-reviews.appspot.com/61809/diff/1/8#newcode27
> Line 27: * <ul class="css">
> We now use <dl>, even though the doc hasn't been updated yet.
>
> http://gwt-code-reviews.appspot.com/61809/diff/1/9
> File user/src/com/google/gwt/user/client/ui/SubmitButton.java (right):
>
> http://gwt-code-reviews.appspot.com/61809/diff/1/9#newcode2
> Line 2: * Copyright 2006 Google Inc.
> 2009
>
> http://gwt-code-reviews.appspot.com/61809/diff/1/9#newcode27
> Line 27: * <ul class="css">
> use dl instead
>
> http://gwt-code-reviews.appspot.com/61809
>
> >
>

--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---

Reply via email to