Reviewers: jgw,
Message:
Joel, can you take this review?
Description:
Nukes the deprecated and over complicated
create-the-root-now-create-the-rest-later flow from UiBinder, and in the
process squashes a number of reported and unreported bugs.
Not as big a change as it looks, most of the listed files are a result
of compulsive method name change refactoring.
The real meat is in moving the parsing of the root UiBinder element out
of UiBinderWriter and into its own parser, and greatly simplified
bootstrapping of the parsing process.
Because we now start parsing above the UI, at the ui:UiBinder element,
parseElementToField (was parseWidget) gets a crack at the topmost
element of the UI--it gets treated like every other element, and various
inconsistencies in its handling (esp. with {computed.attributes} and
localizable ones) evaporate.
Please review this at http://gwt-code-reviews.appspot.com/62810
Affected files:
M user/src/com/google/gwt/uibinder/client/AbstractUiBinder.java
M user/src/com/google/gwt/uibinder/client/DomHolder.java
M user/src/com/google/gwt/uibinder/client/UiBinder.java
M user/src/com/google/gwt/uibinder/parsers/CellPanelParser.java
M user/src/com/google/gwt/uibinder/parsers/DisclosurePanelParser.java
M user/src/com/google/gwt/uibinder/parsers/DockPanelParser.java
M user/src/com/google/gwt/uibinder/parsers/DomElementParser.java
M user/src/com/google/gwt/uibinder/parsers/HasWidgetsParser.java
M user/src/com/google/gwt/uibinder/parsers/MenuBarParser.java
M user/src/com/google/gwt/uibinder/parsers/MenuItemParser.java
M user/src/com/google/gwt/uibinder/parsers/StackPanelParser.java
M user/src/com/google/gwt/uibinder/parsers/TabPanelParser.java
M user/src/com/google/gwt/uibinder/parsers/WidgetInterpreter.java
M
user/src/com/google/gwt/uibinder/parsers/WidgetPlaceholderInterpreter.java
M user/src/com/google/gwt/uibinder/rebind/FieldWriter.java
M user/src/com/google/gwt/uibinder/rebind/HandlerEvaluator.java
A user/src/com/google/gwt/uibinder/rebind/UiBinderParser.java
M user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
M
user/src/com/google/gwt/uibinder/rebind/messages/PlaceholderInterpreter.java
M user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java
M user/src/com/google/gwt/uibinder/sample/client/DomBasedUi.java
M user/src/com/google/gwt/uibinder/sample/client/DomBasedUi.ui.xml
--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---
