Reviewers: amitmanjhi, jat, Description: I see both sides of the fail/permit argument here, but we're seeing a lot of flake to be penalizing everyone for it. Can we agree to run the tests, but make them non-blocking?
The admitted danger is that we never fix the problem, and so never run the tests "in anger"... but at the moment we have a problem we're so far failing to fix, and a dashboard that looks much too angry. Please review this at http://gwt-code-reviews.appspot.com/65801 Affected files: user/build.xml Index: user/build.xml =================================================================== --- user/build.xml (revision 6077) +++ user/build.xml (working copy) @@ -175,11 +175,47 @@ <target name="test.web.htmlunit" depends="compile, compile.tests" description="Run htmlunit web-mode tests for this project."> <!-- TODO: add more browsers later --> <fileset id="test.web.htmlunit.tests" dir="${javac.junit.out}" includes="${gwt.junit.testcase.web.includes}" excludes="${gwt.junit.testcase.web.excludes}" /> - <gwt.junit test.args="${test.args} -htmlunit FF3" test.out="${junit.out}/${build.host.platform}-htmlunit-web-mode" test.cases="test.web.htmlunit.tests" > - <extraclasspaths> + + <taskdef name="junit" classname="org.apache.tools.ant.taskdefs.optional.junit.JUnitTask"> + <classpath> + <pathelement location="${gwt.tools.lib}/junit/junit-3.8.1.jar" /> + <pathelement location="${gwt.tools.antlib}/ant-junit-1.6.5.jar" /> + <pathelement location="${gwt.tools.lib}/selenium/selenium-java-client-driver.jar" /> + </classpath> + </taskdef> + + <echo message="Writing test results to ${junit.out}/${build.host.platform}-htmlunit-web-mode/reports for test.web.htmlunit.tests" /> + <mkdir dir="${junit.out}/${build.host.platform}-htmlunit-web-mode/reports" /> + + <echo message="${javac.out} ${javac.junit.out}" /> + <junit dir="${junit.out}/${build.host.platform}-htmlunit-web-mode" fork="yes" printsummary="yes" + failureproperty="htmlunit.failure" tempdir="${junit.out}/${build.host.platform}-htmlunit-web-mode"> + <jvmarg line="${junit.platform.args}" /> + <jvmarg line="-Xmx768m" /> + <sysproperty key="gwt.args" value="${junit.notheadless.arg} ${test.args} -htmlunit FF3" /> + <sysproperty key="java.awt.headless" value="${junit.headless}" /> + <sysproperty key="gwt.devjar" value="${gwt.dev.staging.jar}" /> + <classpath> + <path refid="project.classpath.src" /> + <pathelement location="${gwt.root}/${project.tail}/super" /> + <pathelement location="${gwt.root}/${project.tail}/test" /> + <pathelement location="${javac.junit.out}" /> + <path refid="project.classpath.class" /> + <pathelement location="${gwt.dev.staging.jar}" /> + <pathelement location="${gwt.tools.lib}/junit/junit-3.8.1.jar" /> + <pathelement location="${gwt.tools.lib}/selenium/selenium-java-client-driver.jar" /> + <pathelement location="${gwt.tools.lib}/w3c/sac/sac-1.3.jar" /> + <pathelement location="${gwt.tools.lib}/w3c/flute/flute-1.3.jar" /> <path refid="test.extraclasspath" /> - </extraclasspaths> - </gwt.junit> + </classpath> + + <formatter type="plain" /> + <formatter type="xml" /> + + <batchtest todir="${junit.out}/${build.host.platform}-htmlunit-web-mode/reports"> + <fileset refid="test.web.htmlunit.tests" /> + </batchtest> + </junit> </target> <target name="test.web.disableClassMetadata" depends="compile, compile.tests" description="Run only web-mode tests for this project."> --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
