I've updated the patch to snip the strays and to check for CssResource ancestry.
On Thu, Sep 3, 2009 at 10:40 AM, <[email protected]> wrote: > On 2009/09/03 04:05:36, Ray Ryan wrote: > >> Okay, name -> field was trivial, done. >> > > LGTM so far. I modified a bit of the mail sample to use this, and it > worked a charm. > > A couple of minor nits: > - I assume that DS_Store and ButtonTest are accidentally attached to > this patch. > - Could use some validation on Style interface not extending > CssResource. I failed to do this on my first try, and the error is > pretty deeply obscure, because it's not caught until the compiler sees > it. Don't consider this blocking, though -- just something we should do > before shipping. > > > > http://gwt-code-reviews.appspot.com/64801 > --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
