Reviewers: jgw, Message: Joel, if you really are on vacation I can find another reviewer. But if you aren't...
All the hard parts of http://code.google.com/p/google-web-toolkit/issues/detail?id=3984 are done. We will now generate a CssResource interface for you, though you still have to bring it in from a separate source file. The next step is to allow css inside the ui.xml file, but that'll be easy now that all the groundwork is done. Note that changes were required to CssResourceGenerator to allow it to handle generated CssResource interfaces. Also refactored instantiating PrintWriters and logging--no more redundant copies of die() and warn(), and no more invisible errors logged to stderr instead of the TreeLogger. This cleanup also lead me to move XML knowledge out of UiBinderGenerator and into UiBinderWriter, but that was a completely mechanical refactor--parseXmlResource has not changed. Description: All the hard parts of http://code.google.com/p/google-web-toolkit/issues/detail?id=3984 are done. We will now generate a CssResource interface for you, though you still have to bring it in from a separate source file. The next step is to allow css inside the ui.xml file, but that'll be easy now that all the groundwork is done. Note that changes were required to CssResourceGenerator to allow it to handle generated CssResource interfaces. Also refactored instantiating PrintWriters and logging--no more redundant copies of die() and warn(), and no more invisible errors logged to stderr instead of the TreeLogger. This cleanup also lead me to move XML knowledge out of UiBinderGenerator and into UiBinderWriter, but that was a completely mechanical refactor--parseXmlResource has not changed. Please review this at http://gwt-code-reviews.appspot.com/65805 Affected files: M user/src/com/google/gwt/resources/css/ExtractClassNamesVisitor.java A user/src/com/google/gwt/resources/rg/Counter.java M user/src/com/google/gwt/resources/rg/CssResourceGenerator.java M user/src/com/google/gwt/uibinder/parsers/BeanParser.java M user/src/com/google/gwt/uibinder/rebind/AbstractFieldWriter.java M user/src/com/google/gwt/uibinder/rebind/BundleWriter.java A user/src/com/google/gwt/uibinder/rebind/CssResourceWriter.java M user/src/com/google/gwt/uibinder/rebind/FieldManager.java M user/src/com/google/gwt/uibinder/rebind/FieldWriter.java M user/src/com/google/gwt/uibinder/rebind/FieldWriterOfExistingType.java M user/src/com/google/gwt/uibinder/rebind/FieldWriterOfGeneratedType.java M user/src/com/google/gwt/uibinder/rebind/HandlerEvaluator.java A user/src/com/google/gwt/uibinder/rebind/MortalLogger.java A user/src/com/google/gwt/uibinder/rebind/PrintWriterManager.java M user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java M user/src/com/google/gwt/uibinder/rebind/UiBinderParser.java M user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java M user/src/com/google/gwt/uibinder/rebind/messages/MessagesWriter.java M user/src/com/google/gwt/uibinder/rebind/model/CssResourceGetter.java M user/src/com/google/gwt/uibinder/rebind/model/ImplicitBundle.java A user/src/com/google/gwt/uibinder/rebind/model/ImplicitClientBundle.java A user/src/com/google/gwt/uibinder/rebind/model/ImplicitCssResource.java M user/src/com/google/gwt/uibinder/rebind/model/OwnerClass.java M user/src/com/google/gwt/uibinder/rebind/model/OwnerField.java M user/src/com/google/gwt/uibinder/rebind/model/OwnerFieldClass.java M user/src/com/google/gwt/uibinder/sample/client/WidgetBasedUi.css M user/src/com/google/gwt/uibinder/sample/client/WidgetBasedUi.java M user/src/com/google/gwt/uibinder/sample/client/WidgetBasedUi.ui.xml M user/test/com/google/gwt/uibinder/sample/client/UiBinderTest.java --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
