Reviewers: Lex,
Message:
We were double escaping the contents of placeholders inside HTML
messages. E.g.,
<p>
<ui:msg>I would 'like' a
<span ui:field='foo'>'single'</span> quote
</ui:msg>
</p>
rendered as:
I would 'like' a ''single'' quote
There was already a mechanism in place for this kind of thing, written
for the widgets-in-HTML-messages case (WidgetPlaceholderInterpreter),
but I forgot to use it in HtmlPlaceholderInterpreter.
Added tests and touched up docs while there, hoping to regain my
bearings more quickly next time.
Description:
We were double escaping the contents of placeholders inside HTML
messages. E.g.,
<p>
<ui:msg>I would 'like' a
<span ui:field='foo'>'single'</span> quote
</ui:msg>
</p>
rendered as:
I would 'like' a ''single'' quote
There was already a mechanism in place for this kind of thing, written
for the widgets-in-HTML-messages case (WidgetPlaceholderInterpreter),
but I forgot to use it in HtmlPlaceholderInterpreter.
Added tests and touched up docs while there, hoping to regain my
bearings more quickly next time.
Please review this at http://gwt-code-reviews.appspot.com/64810
Affected files:
M user/src/com/google/gwt/uibinder/parsers/HTMLPanelParser.java
M user/src/com/google/gwt/uibinder/parsers/HtmlMessageInterpreter.java
M user/src/com/google/gwt/uibinder/parsers/HtmlPlaceholderInterpreter.java
M
user/src/com/google/gwt/uibinder/rebind/messages/PlaceholderInterpreter.java
M user/src/com/google/gwt/uibinder/sample/client/WidgetBasedUi.java
M user/src/com/google/gwt/uibinder/sample/client/WidgetBasedUi.ui.xml
M user/test/com/google/gwt/uibinder/sample/client/UiBinderTest.java
--~--~---------~--~----~------------~-------~--~----~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~----------~----~----~----~------~----~------~--~---
