Thanks, Lex. I've replied inline. I'll address your concerns and submit.
http://gwt-code-reviews.appspot.com/65805/diff/1/4 File user/src/com/google/gwt/resources/rg/CssResourceGenerator.java (right): http://gwt-code-reviews.appspot.com/65805/diff/1/4#newcode1403 Line 1403: checksum.update(Util.getBytes(type.getQualifiedSourceName())); Nope, because this method is still only called in the "if we have no cache yet" case in initReplacements(). http://gwt-code-reviews.appspot.com/65805/diff/1/4#newcode1572 Line 1572: * impossible for other generators to produce CssResource interfaces. Well that's good news. I think this code could get a bit less complicated given that. I'll update the TODO accordingly. http://gwt-code-reviews.appspot.com/65805/diff/1/23 File user/src/com/google/gwt/uibinder/rebind/model/ImplicitCssResource.java (right): http://gwt-code-reviews.appspot.com/65805/diff/1/23#newcode60 Line 60: */ On 2009/09/09 13:18:53, Lex wrote: > Auto-generated comment. Done. http://gwt-code-reviews.appspot.com/65805/diff/1/23#newcode86 Line 86: urls[i++] = found.nextElement(); Somehow never noticed that method. Fixed here and in UiBinderWriter, thanks. http://gwt-code-reviews.appspot.com/65805 --~--~---------~--~----~------------~-------~--~----~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~----------~----~----~----~------~----~------~--~---
